Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
I believe that if we set the input box width to 100%, we may also need to adjust the button alignment, as it does not appear to be properly aligned at the moment. It should support alignment options such as right, center, or left, as appropriate. Just sharing my thoughts. Currently, it appears as shown here: https://prnt.sc/GRIgTITSt3Zr |
sabernhardt
left a comment
sabernhardt
left a comment
There was a problem hiding this comment.
The floating issue already happened in WordPress 6.9, but it is more noticeable now. The floating labels' top margin is too small for the larger input size.
The Add to Menu button alignment expects multiple elements in the .button-controls container with justify-content: space-between. The Custom Links section only has the one button, and that could use justify-content: flex-end. When JS is turned off, other sections can hide the Select All checkbox, moving the Add to Menu button closer to the center.
I would also like to remove the howto class from the labels because the gray text seems more inappropriate now.
| .menu-item-textbox { | ||
| width: 180px; | ||
| width: 100%; |
There was a problem hiding this comment.
Editing the current .menu-item-textbox ruleset seems safe with core, but I would be more comfortable setting full width on .customlinkdiv .menu-item-textbox (especially during beta).
.menu-item-textbox {
width: 180px;
}
.customlinkdiv .menu-item-textbox {
width: 100%;
}
Core adds the menu-item-textbox class to Custom Link controls both on the Menus page and in the Customizer. The Menus page also uses the class for the Menu name, but that is set to 270px.
A plugin directory search found some plugins using the class, though more than one of them already assigned 100% width.
| /* Add Menu Item Boxes */ | ||
| .postbox .howto input, | ||
| .customlinkdiv .menu-item-textbox, | ||
| .customlinkdiv .error-message { |
There was a problem hiding this comment.
If the input is full width, the error message would not need the float or reduced width either.
3 participants
https://core.trac.wordpress.org/ticket/64692